Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46178: Use new query system in Prompt Processing #4151

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

kfindeisen
Copy link
Collaborator

This PR removes a Prompt Processing debugging flag that was sometimes needed to get correct results with the old calib-handling code removed on lsst-dm/prompt_processing#249.

Copy link

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really qualified to review Phalanx changes, but to the extent I can infer what this is doing, it looks fine.

The flag was a workaround for another workaround for a bug in how
calibs were loaded into local repos. Now that loading is done
correctly, there's no need for the override.
@kfindeisen kfindeisen enabled auto-merge January 31, 2025 18:08
@kfindeisen kfindeisen added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 1951bfd Jan 31, 2025
7 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-46178 branch January 31, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants