DM-48923: Provide Times Square support for date and date-time parameters #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1a6cbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Mar 3, 2025
This version of Squareone adds support for date and date-time parameters in Times Square. lsst-sqre/squareone#183
This will provide access to date and date-time formats. See https://github.com/ajv-validator/ajv-formats
It seems that the touched prop isn't getting set properly anymore, so that was supressing the error messages. Next step is to double check the behaviour of the touched prop.
The stock error message is simply: - must match format "date" - must match format "date-time" These messages explain the ISO format.
jonathansick
force-pushed
the
tickets/DM-48923
branch
from
20fa439 to
a1a6cbe
Compare
Merged
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Mar 6, 2025
This version of Squareone adds support for date and date-time parameters in Times Square. lsst-sqre/squareone#183 https://github.com/lsst-sqre/squareone/releases/tag/squareone%400.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Times Square now supports string parameters with date and date-time formats. The error messages remind the user about the ISO 8601 date / datetime formats. A timezone is required for date-time parameters.