Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/SITCOM-1642 #148

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Tickets/SITCOM-1642 #148

merged 1 commit into from
Feb 10, 2025

Conversation

kpmort97
Copy link
Contributor

@kpmort97 kpmort97 commented Feb 3, 2025

Added a SAL Scripts section to AuxTel page. The new section contains tables of common AuxTel operation scripts created on the "LOVE AT Useful lower level command scripts and configurations" confluence page.

@kpmort97 kpmort97 self-assigned this Feb 3, 2025
Copy link
Contributor

@kpenaramirez kpenaramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kris. Excellent work with rEST!!!. You are now our table expert!

- To change Nasmyth to port 1:

.. code-block:: text

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put this code inside a run_command.py collapsable block?

- To specify the az/el position as well as the filter:

.. code-block:: text

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put this code inside a SAL Script collapsable block?


component: ATPneumatics
cmd: closeM1Cover

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the two previous blocks of code into a run_command.py collapsable block?

Copy link
Contributor

@isotuela isotuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, excellent table! Thank you.

The content is ready to merge! But before merging, you need to rebase your branch (or it won´t allow merging) and squash both commits into 1. (to make git history nicer to read) Let me know if you need help with this.

Cheers,
Ioaan

@kpmort97 kpmort97 force-pushed the tickets/SITCOM-1642 branch 3 times, most recently from 6a8dc65 to 475b456 Compare February 10, 2025 14:16
@kpmort97
Copy link
Contributor Author

Kate reviewed this ticket and sent the following comments:

set_summary_state.py --> run_command.py --> should cmd be enable or enabled? For the SAL script, it says ENABLED.
Is the cmd in run_command.py also case blind? If so, I'd add a statement similar to what is written for the SAL script.
In the section called AuxTel Scheduler, under the CSC Scheduler.2 section Script Configuration column, I'd change "The scripts resume.py and stop.py require No configurations" to "The scripts resume.py and stop.py do not require configurations." Are there never configurations or are they optional?
In the ATAOS row, there is a warning that says "Only run these commands when the telescope pointing is at high elevation." Can you quantify how high the elevation needs to be? 60 deg? 70 deg?
Is there no run_command for ATSpectrograph Optical alignment of AT with LATISS?

@kpmort97 kpmort97 force-pushed the tickets/SITCOM-1642 branch from 896ae3c to e989b1d Compare February 10, 2025 14:37
Added a SAL Scripts section to AuxTel page. New Section contains tables of common AuxTel operation scripts.

Combined 3 commits into 1.

Updated document title and navigation bar for easier access to webpage.

Changed heading sizes and created markdown tabs for all non-empty script configurations.

Removed unnecessary index.rst file.

Added Karla, Ioana, and Kate as contributors.

Updated page with comments from Kate Napier.
@kpmort97 kpmort97 force-pushed the tickets/SITCOM-1642 branch from e989b1d to b16c4c7 Compare February 10, 2025 14:47
@kpmort97 kpmort97 merged commit 96b7bb3 into main Feb 10, 2025
2 checks passed
@kpmort97 kpmort97 deleted the tickets/SITCOM-1642 branch February 10, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants