Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wavelength and OpticalConfiguration Bugs #62

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Wavelength and OpticalConfiguration Bugs #62

merged 2 commits into from
Feb 14, 2025

Conversation

parfa30
Copy link
Contributor

@parfa30 parfa30 commented Feb 11, 2025

There are two bugs found in the Tunable Laser CSC through some testing on TTS:

  1. changeWavelength should actually be a long integer, rather than a float
  2. When configuring the CSC with the main laser, we don’t actually set the event of the opticalConfiguration

@parfa30 parfa30 requested a review from couger01 February 11, 2025 18:09
couger01
couger01 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@couger01 couger01 merged commit 725d0ae into develop Feb 14, 2025
1 check passed
@couger01 couger01 deleted the tickets/DM-48890 branch February 14, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@couger01 couger01 couger01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parfa30 @couger01