DM-48494: PsfMatch cleanups while exploring AL+DF kernel basis #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Feb 5, 2025
parejkoj
force-pushed
the
tickets/DM-48494
branch
from
1163504 to
a88b39d
Compare
Use super() Remove unnecessary self.kConfig: this is already done in the parent class.
parejkoj
force-pushed
the
tickets/DM-48494
branch
from
a88b39d to
188a2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combined kernel basis didn't work out, but I pushed my exploration of that onto tickets/DM-48494-nomerge, which I'll rebase onto main once this merges. These are just some cleanups I made along the way while exploring that.