DM-48704: Invert negative footprints for deblending in DIA #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've invited @jsv1206 to review (Sreevani Jarugula) on Jira, but it appears she'll be needed to add to the appropriate orgs to submit a review on GitHub. |
Contributor
|
I have sent @jsv1206 an invite. |
Contributor
Author
|
The test is a work in progress. It presently passes, BUT it also passes without the bugfix. |
This does not fix a separate footprint merging bug.
mrawls
force-pushed
the
tickets/DM-48704
branch
from
3e7f22d to
3079de2
Compare
While this test passes, it does NOT catch the original failure condition, i.e., raising if deblending sources yields entirely nan peaks.
mrawls
force-pushed
the
tickets/DM-48704
branch
from
3079de2 to
34afd92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in deblending diaSources that have negative fluxes. It does not fix a separate footprint merging bug.