DM-48807: Add detectAndMeasure negative peak tests #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
force-pushed
the
tickets/DM-48807
branch
from
b4ec4d1 to
a9ef7dd
Compare
mrawls
changed the title
We reverted the fix and demonstrated that the spans were empty in footprints with negative peaks; this test checks that they are not.
This reverts commit 34afd92. This addition did not trigger the bug nor test the fix.
mrawls
force-pushed
the
tickets/DM-48807
branch
from
a9ef7dd to
9d2486d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the bug fixed in DM-48704.