DM-47642: Update AL deconvolution to share code with convolution case. #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-47642
branch
from
8d36cb7 to
2d2eeb5
Compare
As noted on the ticket (https://rubinobs.atlassian.net/browse/DM-47642), the original motivation for the choice of basis functions for the deconvolution kernel appears to have been a misinterpretation of the cited paper. The simpler approach gives comparable results, is easier to modify, and does not give the illusion of a mathematical foundation.
isullivan
force-pushed
the
tickets/DM-47642
branch
from
2d2eeb5 to
1c7735d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted on the ticket (https://rubinobs.atlassian.net/browse/DM-47642), the original motivation for the choice of basis functions for the deconvolution kernel appears to have been a misinterpretation of the cited paper. The simpler approach gives comparable results, is easier to modify, and does not give the illusion of a mathematical foundation.
The new configs result in a better subtraction for one unit test that used deconvolution, so the test value needed to be updated.