DM-49071: Do not save zero length diaSource catalogs #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-49071
branch
from
464fef1 to
d3fc441
Compare
fred3m
changed the title
fred3m
changed the title
TallJimbo
approved these changes
Feb 27, 2025
|
|
||
| if len(diaSources) > 0: | ||
| measurementResults.diaSources = diaSources | ||
|
|
Member
There was a problem hiding this comment.
I missed the conversation happening in real time (I was dropping off someone at the airport) but my first thought here is that this is going to get cumbersome in the long run. But I see Jim has approved (thanks Jim) and I need to catch up on the thread before I have strong opinions.
fred3m
force-pushed
the
tickets/DM-49071
branch
from
d3fc441 to
b4a3357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.