Skip to content

DM-49274: Add flag_nodata into SourceFlagChecker bad flags #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leeskelvin merged 1 commit into from
Mar 25, 2025
Merged

DM-49274: Add flag_nodata into SourceFlagChecker bad flags #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/lsst/ip/diffim/dipoleMeasurement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,12 @@ class SourceFlagChecker(object):
"""Functor class to check whether a diaSource has flags set that should cause it to be labeled bad."""

def __init__(self, sources, badFlags=None):
self.badFlags = ['base_PixelFlags_flag_edge', 'base_PixelFlags_flag_interpolatedCenter',
'base_PixelFlags_flag_saturatedCenter']
self.badFlags = [
"base_PixelFlags_flag_edge",
"base_PixelFlags_flag_nodata",
"base_PixelFlags_flag_interpolatedCenter",
"base_PixelFlags_flag_saturatedCenter",
]
Comment on lines +144 to +149
Copy link
Contributor

@mrawls mrawls Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is used anywhere, but I agree in principle that nodata belongs here alongside edge

if badFlags is not None:
for flag in badFlags:
self.badFlags.append(flag)
Expand Down