DM-50843: Add residual QA metric to detectAndMeasure #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-50843
branch
from
1163c4a to
1325264
Compare
erinleighh
approved these changes
May 23, 2025
Contributor
erinleighh
left a comment
erinleighh
left a comment
There was a problem hiding this comment.
Everything looks good! The only thing I was iffy on was the use of the single character variable n in line 871 of detectAndMeasure.py, but I think it's obvious enough what you're doing that it doesn't need a more descriptive variable name. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The residual metric is needed in detectAndMeasure in addition to subtractImages, because background subtraction is now done in detectAndMeasure.