DM-51368: Move kernel candidate residual metric to utils #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
approved these changes
Jun 12, 2025
Contributor
fred3m
left a comment
fred3m
left a comment
There was a problem hiding this comment.
LGTM. A few docstrings need to be updated and I left a note about a potential issue that might need to be investigated in another ticket.
|
|
||
| @timeMethod | ||
| def run(self, science, matchedTemplate, difference, | ||
| def run(self, science, matchedTemplate, difference, kernelSources, |
Contributor
There was a problem hiding this comment.
Don't forget to add kernelSources to the docstring.
| mask &= ~mask.getPlaneBitMask(self.config.clearMaskPlanes) | ||
|
|
||
| def processResults(self, science, matchedTemplate, difference, sources, idFactory, | ||
| def processResults(self, science, matchedTemplate, difference, sources, idFactory, kernelSources, |
Contributor
There was a problem hiding this comment.
Please update this docstring too.
| diaSource.assign(forcedSource, mapper) | ||
|
|
||
| def calculateMetrics(self, science, difference, diaSources): | ||
| def calculateMetrics(self, science, difference, diaSources, kernelSources): |
|
|
||
| @timeMethod | ||
| def run(self, science, matchedTemplate, difference, scoreExposure, | ||
| def run(self, science, matchedTemplate, difference, scoreExposure, kernelSources, |
isullivan
force-pushed
the
tickets/DM-51368
branch
from
9c08354 to
cbadd64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.