DM-51635: LSSTCam DRP error in subtractImages with undefined maglim #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
changed the title
isullivan
approved these changes
Jul 1, 2025
Contributor
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
Approved, but please see my comment to help prevent this from happening again in the future.
| try: | ||
| psf = exposure.getPsf() | ||
| psf_shape = psf.computeShape(psf.getAveragePosition()) | ||
| except (lsst.pex.exceptions.InvalidParameterError, afwDetection.InvalidPsfError): |
Contributor
There was a problem hiding this comment.
Any exception that is not in this list will raise an error in the finally step, since maglim won't be defined. I think this would be a good place to use except Exception as e to catch any exception, and print the error message in the log. Alternately, you could define maglim = np.nan before the try block to guarantee that it is defined.
Contributor
Author
There was a problem hiding this comment.
Good point, thanks - I like the idea to just set it to nan upfront so we at least wind up with something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug as reported, but does not fix the underlying issue of why the PSF cannot be evaluated at the average position for this image. I looked at the visit (detector=150, visit=2025060400401) that caused the failure on RubinTV and didn't see anything obviously wrong or unusual.