DM-50988: Flag DIASources consistent with glints from rotating space junk #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
force-pushed
the
tickets/DM-50988
branch
2 times, most recently
from
d3a454b to
101fa39
Compare
ebellm
requested changes
Jul 18, 2025
| Parameters of all the trails that were found. | ||
| """ | ||
| trailed_glints = self.findGlints.run(diaSources) | ||
| glint_mask = [True if id in trailed_glints.trailed_ids else False for id in diaSources['id']] |
Contributor
There was a problem hiding this comment.
Suggested change
| glint_mask = [True if id in trailed_glints.trailed_ids else False for id in diaSources['id']] | |
| glint_mask = [id in glint_trails.trailed_ids for id in diaSources['id']] |
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this!
| # Check that the entire image was not masked STREAK | ||
| self.assertFalse(np.all(streakMaskSet)) | ||
|
|
||
| def test_trailed_glints(self): |
Contributor
There was a problem hiding this comment.
It would be good to test that writeGlintInfo provides the expected outputs as well.
mrawls
force-pushed
the
tickets/DM-50988
branch
3 times, most recently
from
ddf42fb to
6d6bfe0
Compare
ebellm
approved these changes
Jul 24, 2025
Adds a new bool column to the diaSource catalog. In addition, a new catalog with fit trail info is persisted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag column to the dia_source_detector table called
trailed_glint. DiaSources with this flag fall along a suspected glint trail.This PR also creates a new data product called
trailed_glintsthat is written out by the Butler. It is a dict with all the fields defined in GlintTrailParameters (in meas_algorithms findGlintTrails.py).