DM-52106: Image differencing cleanups #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value will always be zero. This should have been removed when the relevant code was deleted in DM-51360
BrunoSanchez
approved these changes
Aug 12, 2025
Member
BrunoSanchez
left a comment
BrunoSanchez
left a comment
There was a problem hiding this comment.
Some minor comments, but changes look good to me.
It improves the flow of the subtractImages.py file.
| doSubtractBackground = lsst.pex.config.Field( | ||
| doc="Subtract the background fit when solving the kernel?", | ||
| doc="Subtract the background fit when solving the kernel?" | ||
| " It is generally better to instead subtract the background in detectAndMeasure.", |
Member
There was a problem hiding this comment.
Space would go in line 176
|
|
||
| def _sourceSelector(self, sources, mask): | ||
| def _sourceSelector(self, sources, bbox): | ||
| """Select sources from a catalog that meet the selection criteria. |
Member
There was a problem hiding this comment.
I think that the docstring doesn't reflect exactly what the method is doing.
What about:
"""Select catalog sources that fall inside the provided bounding box,
with an edge proximity rejection as configured in `restrictKernelEdgeSources`.
"""
| selected = self.sourceSelector.selectSources(sources).selected | ||
| if self.config.restrictKernelEdgeSources: | ||
| rejectRadius = 2*self.config.makeKernel.kernel.active.kernelSize | ||
| bbox.grow(-rejectRadius) |
Member
There was a problem hiding this comment.
Cool, I didn't know about this.
Comment on lines
521
to
525
| try: | ||
| try: |
Member
There was a problem hiding this comment.
Explain better this double try block, and make explicit the logic of this flow control.
isullivan
force-pushed
the
tickets/DM-52106
branch
from
ffb9016 to
97d6a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a number of cleanups from DM-44936, which is not expected to merge soon.