Skip to content

DM-49090: Remove getOverlappingExposures from GetTemplateTask #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abudlong merged 3 commits into from
Oct 6, 2025
Merged

DM-49090: Remove getOverlappingExposures from GetTemplateTask #437

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791f75a
Remove getOverlappingExposures from GetTemplateTask
abudlong Oct 1, 2025
34d1f09
Remove getOverlappingExposures from GetDcrTemplateTask
abudlong Oct 1, 2025
1d5b2c4
Update imports
abudlong Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions python/lsst/ip/diffim/getTemplate.py
View file
Open in desktop
Copy link
Contributor

@bsmartradio bsmartradio Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume the GetDcrTemplateTask depreciation was added in a ticket that wasn't mentioned in the DM-49090 description? Since the description only links to a ticket that was marked as Wasn't Fixed, could you add in the comments which ticket added the depreciation so it's clear when it was depreciated?

Copy link
Contributor Author

@abudlong abudlong Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Jira ticket description to include DM-49344 which deprecated getOverlappingExposures in the GetDcrTemplateTask.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import collections

import numpy as np
from deprecated.sphinx import deprecated

import lsst.afw.image as afwImage
import lsst.geom as geom
Expand Down Expand Up @@ -190,17 +189,6 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs):
)
butlerQC.put(outputs, outputRefs)

@deprecated(
reason="Replaced by getExposures, which uses explicit arguments instead of a kwargs dict. "
"This method will be removed after v29.",
version="v29.0",
category=FutureWarning,
)
def getOverlappingExposures(self, inputs):
return self.getExposures(
inputs["coaddExposures"], inputs["bbox"], inputs["skyMap"], inputs["wcs"]
)

def getExposures(self, coaddExposureHandles, bbox, skymap, wcs):
"""Return a data structure containing the coadds that overlap the
specified bbox projected onto the sky, and a corresponding data
Expand Down Expand Up @@ -698,21 +686,6 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs):
)
butlerQC.put(outputs, outputRefs)

@deprecated(
reason="Replaced by getExposures, which uses explicit arguments instead of a kwargs dict. "
"This method will be removed after v29.",
version="v29.0",
category=FutureWarning,
)
def getOverlappingExposures(self, inputs):
return self.getExposures(
inputs["dcrCoadds"],
inputs["bbox"],
inputs["skyMap"],
inputs["wcs"],
inputs["visitInfo"],
)

def getExposures(self, dcrCoaddExposureHandles, bbox, skymap, wcs, visitInfo):
"""Return lists of coadds and their corresponding dataIds that overlap
the detector.
Expand Down