Skip to content

DM-49059: Stand-up an obs_decam calibrateImage config script#251

Merged
leeskelvin merged 1 commit intomainfrom
tickets/DM-49059
Feb 26, 2025
Merged

DM-49059: Stand-up an obs_decam calibrateImage config script#251
leeskelvin merged 1 commit intomainfrom
tickets/DM-49059

Conversation

@leeskelvin
Copy link
Contributor

No description provided.

Comment on lines 10 to 12
config.astrometry_ref_loader.load(os.path.join(config_dir, "filterMap.py"))
# Use the filterMap instead of the "any" filter (as is used for Gaia)
config.astrometry_ref_loader.anyFilterMapsToThis = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No filterMap for Gaia: you want anyFilterMapsToThis = "phot_g_mean", which is the default anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited to phot_g_mean for clarity. Should I also remove the ref_loader filterMap.py line above?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: anyFilterMapsToThis and a filterMap are mutually exclusive (and should raise an error if both are set).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed - much cleaner now, thanks. Tested to confirm this all works on DECam data here at Princeton.

config_dir = os.path.dirname(__file__)

# Astrometry
config.connections.astrometry_ref_cat = "gaia_dr3_20230707"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd not include this, and the photometry_ref_cat below, since they're the default. If you are going to respecify the default, please put a comment as to why.

config.photometry_ref_loader.load(os.path.join(config_dir, "filterMap.py"))

# Adopt HSC calibrateImage defaults while older defaults are compared
config.install_simple_psf.fwhm = 1.5 * 2.0 * math.sqrt(2.0 * math.log(2.0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this if you want, but I'd try running it with the calibrateImage default and see. I don't think this HSC setting really translates to DECam, since they have different pixel scales and seeing.


# Adopt HSC calibrateImage defaults while older defaults are compared
config.install_simple_psf.fwhm = 1.5 * 2.0 * math.sqrt(2.0 * math.log(2.0))
config.psf_detection.thresholdType = "stdev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DECam shouldn't have the same variance problem that HSC does, so I'd go with the default here.

@leeskelvin leeskelvin merged commit 0fba68d into main Feb 26, 2025
2 checks passed
@leeskelvin leeskelvin deleted the tickets/DM-49059 branch February 26, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants