Skip to content

Change default values for SSObject per-band parameters #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gerenjie wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change default values for SSObject per-band parameters #1249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec4d449
Change default values for SSObject per-band parameters
Gerenjie Feb 5, 2026
6dcf3cb
Use HG12 nDof = nObs - 2
Gerenjie Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/lsst/pipe/tasks/ssp/ssobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,15 @@ def compute_ssobject_entry(row, sss):
df = sss[sss["dia_band"] == band]

# set defaults for this band (equivalents of NULL)
row[f"{band}_Chi2"] = -1
row[f"{band}_Chi2"] = np.nan
row[f"{band}_G12"] = np.nan
row[f"{band}_G12Err"] = np.nan
row[f"{band}_H"] = np.nan
row[f"{band}_H_{band}_G12_Cov"] = np.nan
row[f"{band}_HErr"] = np.nan
row[f"{band}_nObsUsed"] = -1
row[f"{band}_nObsUsed"] = 0
row[f"{band}_phaseAngleMin"] = np.nan
row[f"{band}_phaseAngleMax"] = np.nan

nBandObs = len(df)
row[f"{band}_nObs"] = nBandObs
Expand All @@ -97,7 +99,7 @@ def compute_ssobject_entry(row, sss):
H, G12, sigmaH, sigmaG12, covHG12, chi2dof, nobsv = photfit.fitHG12(
df["dia_psfMag"], df["dia_psfMagErr"], df["phaseAngle"], df["topoRange"], df["helioRange"]
)
nDof = 2
nDof = nBandObs - 2
# print(provID, band, H, G12, sigmaH, sigmaG12, covHG12,
# chi2dof, nobsv)

Expand Down