Skip to content

Fix SPA routing for production builds - serve index.html on 404 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Fix SPA routing for production builds - serve index.html on 404 #58

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd02bbb
Initial plan
Copilot Feb 18, 2026
aa8231e
Fix SPA routing for multiuser mode by handling 404s in NoCacheStaticF…
Copilot Feb 18, 2026
040dffc
Improve type hint for scope parameter to use Scope type from starlett…
Copilot Feb 18, 2026
e186ab4
Merge branch 'feature/multiuser' into copilot/fix-not-found-errors-mu…
lstein Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions invokeai/app/api/no_cache_staticfiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

Static files include the javascript bundles, fonts, locales, and some images. Generated
images are not included, as they are served by a router.

Check failure on line 17 in invokeai/app/api/no_cache_staticfiles.py

View workflow job for this annotation

GitHub Actions / python-checks

Ruff (W293) 

invokeai/app/api/no_cache_staticfiles.py:17:1: W293 Blank line contains whitespace
This class also implements proper SPA (Single Page Application) routing by serving index.html
for any routes that don't match static files, enabling client-side routing to work correctly
in production builds.
Expand All @@ -36,7 +36,7 @@
async def get_response(self, path: str, scope: Scope) -> Response:
"""
Override get_response to implement SPA routing.

Check failure on line 39 in invokeai/app/api/no_cache_staticfiles.py

View workflow job for this annotation

GitHub Actions / python-checks

Ruff (W293) 

invokeai/app/api/no_cache_staticfiles.py:39:1: W293 Blank line contains whitespace
When a file is not found and html mode is enabled, serve index.html instead of raising a 404.
This allows client-side routing to work correctly in SPAs.
"""
Expand Down
Loading