Skip to content

Comments

Consolidate multiuser DB migrations 27–29 into a single migration step#71

Merged
lstein merged 2 commits intofeature/multiuserfrom
copilot/consolidate-database-migrations
Feb 20, 2026
Merged

Consolidate multiuser DB migrations 27–29 into a single migration step#71
lstein merged 2 commits intofeature/multiuserfrom
copilot/consolidate-database-migrations

Conversation

Copy link

Copilot AI commented Feb 20, 2026

Summary

Migrations 27, 28, and 29 were added separately during multiuser branch development. Since none have shipped, consolidate them into a single atomic migration step (26→27).

Changes:

  • migration_27.py: Absorbs all logic from 28 and 29 — multi-user tables, user_id columns on existing tables, client_state per-user restructuring (including old-schema data migration), and app_settings table with JWT secret generation
  • migration_28.py / migration_29.py: Deleted
  • sqlite_util.py: Removed imports and registrations for build_migration_28 / build_migration_29
  • tests/test_sqlite_migrator.py: Replaced separate test_migration_27_* / test_migration_28_* tests with consolidated tests covering users tables, client_state migration paths (with/without existing data column), and app_settings/JWT secret

Related Issues / Discussions

QA Instructions

Run pytest tests/test_sqlite_migrator.py. All 22 tests should pass.

Merge Plan

This touches the DB migration chain. Verify no environments have already run migration 28 or 29 before merging — if they have, a gap-filling migration will be needed instead.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
Copilot AI changed the title [WIP] Consolidate database migrations into a single step Consolidate multiuser DB migrations 27–29 into a single migration step Feb 20, 2026
Copilot AI requested a review from lstein February 20, 2026 20:57
@lstein lstein marked this pull request as ready for review February 20, 2026 21:43
@lstein lstein merged commit 24a7153 into feature/multiuser Feb 20, 2026
25 of 31 checks passed
@lstein lstein deleted the copilot/consolidate-database-migrations branch February 20, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants