-
-
Notifications
You must be signed in to change notification settings - Fork 209
Providing Pipe Function see #141 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tzkmx
wants to merge
7
commits into
lstrojny:main
Choose a base branch
from
apantle:dev-pipe-function
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e461a0d
Providing Pipe Function w/multiple entry arguments
tzkmx 1a8a01a
Merge remote-tracking branch 'lars/master' into dev-pipe-function
tezcatl 302f217
using mock objects for PipeTest
tezcatl 5161029
dropping functional implementation for Functor
tezcatl e0a8eb1
fixed Pipe Tests
tezcatl 0a9726d
fixing style nagging
tezcatl 6f9ac1a
prefix count function with a "
tezcatl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
<?php | ||
|
||
/** | ||
* Copyright (C) 2019, 2020 by Jesus Franco Martinez <tezcatl@fedoraproject.org> | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
*/ | ||
|
||
namespace Functional; | ||
|
||
use Functional\Exceptions\InvalidArgumentException; | ||
|
||
/** | ||
* Provides a functor that applies the functions passed at construction | ||
* from left to right, first function is able to admit several arguments | ||
* at once. | ||
* | ||
* @link https://github.com/lstrojny/functional-php/issues/141 | ||
* @param callable[] ...$functions functions to be composed | ||
* @return callable | ||
*/ | ||
function pipe(...$functions): callable | ||
{ | ||
return new Pipe($functions); | ||
} | ||
|
||
class Pipe | ||
{ | ||
/** @var callable[] */ | ||
protected $callables; | ||
|
||
protected $carry; | ||
|
||
protected $pipeLength = 0; | ||
|
||
public function __construct(array $functions) | ||
{ | ||
$this->pipeLength = \count($functions); | ||
if ($this->pipeLength < 2) { | ||
throw new InvalidArgumentException( | ||
'You should pass at least 2 functions or functors to build a pipe' | ||
); | ||
} | ||
foreach ($functions as $index => $callable) { | ||
InvalidArgumentException::assertCallback($callable, 'pipe', $index + 1); | ||
$this->callables[] = $callable; | ||
} | ||
} | ||
|
||
public function __invoke() | ||
{ | ||
$funArgs = \func_get_args(); | ||
$this->carry = \call_user_func_array($this->callables[0], $funArgs); | ||
|
||
for ($index = 1; $index < $this->pipeLength; $index++) { | ||
$this->carry = \call_user_func( | ||
$this->callables[$index], | ||
$this->carry | ||
); | ||
} | ||
|
||
return $this->carry; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
<?php | ||
|
||
/** | ||
* Copyright (C) 2019, 2020 by Jesus Franco Martinez <tezcatl@fedoraproject.org> | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
*/ | ||
|
||
namespace Functional\Tests; | ||
|
||
use Functional\Exceptions\InvalidArgumentException; | ||
|
||
use function Functional\pipe; | ||
|
||
class PipeTest extends AbstractTestCase | ||
{ | ||
public function testPipeFunction() | ||
{ | ||
$mockFirst = $this->getClosureMock(1, ['o', 'n', 'e'], 'one'); | ||
$mockSecond = $this->getClosureMock(1, ['one'], 'one, two'); | ||
$mockThird = $this->getClosureMock(1, ['one, two'], 'one, two, three'); | ||
|
||
$result = pipe( | ||
$mockFirst, | ||
$mockSecond, | ||
$mockThird | ||
)('o', 'n', 'e'); | ||
|
||
$this->assertEquals('one, two, three', $result); | ||
} | ||
|
||
public function testShouldNotAcceptSingleFunction() | ||
{ | ||
$this->expectException(InvalidArgumentException::class); | ||
$this->expectExceptionMessage('You should pass at least 2 functions or functors to build a pipe'); | ||
pipe('strval')(); | ||
} | ||
|
||
/** @dataProvider notQuiteFunctionsProvider */ | ||
public function testExceptionNotCallable($maybeFun1, $maybeFun2, $expectedException) | ||
{ | ||
$this->expectException(InvalidArgumentException::class); | ||
$this->expectExceptionMessage($expectedException); | ||
pipe($maybeFun1, $maybeFun2)(); | ||
} | ||
|
||
public function notQuiteFunctionsProvider() | ||
{ | ||
return [ | ||
[ | ||
'strval', | ||
'__not', | ||
'pipe() expects parameter 2 to be a valid callback, ' . | ||
'function \'__not\' not found or invalid function name' | ||
], | ||
[ | ||
'runabout', | ||
'intval', | ||
'pipe() expects parameter 1 to be a valid callback, ' . | ||
'function \'runabout\' not found or invalid function name' | ||
] | ||
]; | ||
} | ||
|
||
private function getClosureMock( | ||
int $invocations, | ||
array $expectedArguments, | ||
$mustReturnValue | ||
) { | ||
$mock = $this->getMockBuilder(CustomTestClosure::class) | ||
->getMock(); | ||
|
||
$argsArray = []; | ||
for ($index = 0; $index < count($expectedArguments); $index++) { | ||
$argsArray[] = $this->equalTo($expectedArguments[$index]); | ||
} | ||
|
||
$mock->expects($this->exactly($invocations)) | ||
->method('__invoke') | ||
->withConsecutive($argsArray) | ||
->willReturn($mustReturnValue); | ||
return $mock; | ||
} | ||
} | ||
|
||
class CustomTestClosure | ||
{ | ||
public function __invoke() | ||
{ | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.