Offer ContentDB updates for leftover bundled Minetest Game #13906
Conversation
|
@grorp also consider that Minetest game from Minetest 5.4.1 will crash at startup with Minetest 5.8. Newer versions do not crash at startup, but maybe it may make sense to handle crashes of unversioned |
|
This will need changes after #13807 is merged. |
grorp
added
the
Action / change needed
I think pushing users towards updating their packages is enough for now (see #13807). Old versions of other games probably have similar problems. (Also see #13799.) |
grorp
force-pushed
the
leftover-bundled-mtg-offer-updates
branch
from
502b81b to
fbd58ec
Compare
Avoids need for special handling of optional "_game" suffix
|
https://irc.minetest.net/minetest-dev/2023-10-28#i_6126271 I haven't implemented the "backup MTG before updating" thing suggested on IRC, as I'm not sure how to do this best. Where do we want to put the backup? I think it shouldn't show up in the game list. The backup would only be something for experienced users (modders) who have modified their local MTG installation. Also, I'm not sure if a backup is at all needed. After all, every Minetest update before 5.8.0 also overwrote Minetest Game, wiping any modifications made by the user. |
grorp
removed
the
Action / change needed
In the games folder or in the folder above it I guess.
Or maybe it should, as “Minetest Game (Legacy)”? This was suggested on IRC and I currently have no opinion on it. Do all folders in the games folder show up in the game list? If not, what would neet to be done so it does not happen?
I am pretty sure that extracting a zip file does not overwrite everything, just files that are in a zip archive. Meanwhile, I think the update of a mod deletes the entire folder, or not? Btw, anecdotally I can say that players who have little idea how this stuff should work actually do save files for texture sets they are making in the minetest_game folder or copy new mods into it. But since much stronger evidence did not pass through the “I'm pretty sure nothing bad will happen” filter in the past, that's not really an argument. |
We don't need this IMO. |
|
Other than that, code looks good and works as expected |
(It's a string since luanti-org#13906.)
(It's a string since luanti-org#13906.)
Resolves item 3 from #13818 (comment).
Windows users apparently update Minetest by extracting the new ZIP file over their existing installation. This means that Minetest Game will remain installed for them. Since the bundled Minetest Game has no "release" field in its game.conf, it won't receive updates from ContentDB and Windows users will stay on MTG 5.7.0 forever.
This PR fixes that by considering any installation of MTG that is not versioned (i.e. no "release" field), has not been cloned from Git, and is not system-wide to be updatable.
To do
This PR is a Ready for Review.
How to test
Install Minetest Game from ContentDB. Remove the "release" field from game.conf and verify that you are offered an update in the "Browse online content" dialog.