-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help formspec for CSM commands #13937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it duplicates existing help formspec code. Can't that be moved to builtin/common/information_formspecs.lua
?
Here we go, now there is universal function for both server and client help formspecs in information_formspecs.lua |
@@ -86,6 +91,9 @@ end | |||
-- PRIVILEGES FORMSPEC | |||
|
|||
local function build_privs_formspec(name) | |||
if INIT == "client" then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change necessary? If you don't want this to be called by clients, why not do assert(INIT ~= "client")
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works.
This PR adds graphical interface for
.help
command, the similar as used on the server (/help
).How to test
enable_client_modding
totrue
in minetest.conf.help
in the chat and test the functionality of formspec..help -t
and.help all -t
should return output to the chat without using formspec