Skip to content

Fix gcinfo() and collectgarbage("count") to return floating-point KB values #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix gcinfo() and collectgarbage("count") to return floating-point KB values #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CLI/src/Repl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,9 @@ static int lua_collectgarbage(lua_State* L)

if (strcmp(option, "count") == 0)
{
int c = lua_gc(L, LUA_GCCOUNT, 0);
lua_pushnumber(L, c);
int k = lua_gc(L, LUA_GCCOUNT, 0);
int b = lua_gc(L, LUA_GCCOUNTB, 0);
lua_pushnumber(L, double(k) + double(b) / 1024);
return 1;
}

Expand Down
4 changes: 3 additions & 1 deletion VM/src/lbaselib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,9 @@ static int luaB_rawlen(lua_State* L)

static int luaB_gcinfo(lua_State* L)
{
lua_pushinteger(L, lua_gc(L, LUA_GCCOUNT, 0));
int k = lua_gc(L, LUA_GCCOUNT, 0);
int b = lua_gc(L, LUA_GCCOUNTB, 0);
lua_pushnumber(L, (double)k + (double)b / 1024);
return 1;
}

Expand Down
7 changes: 7 additions & 0 deletions tests/Conformance.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ static int lua_collectgarbage(lua_State* L)
int res = lua_gc(L, optsnum[o], ex);
switch (optsnum[o])
{
case LUA_GCCOUNT:
{
int k = lua_gc(L, LUA_GCCOUNT, 0);
int b = lua_gc(L, LUA_GCCOUNTB, 0);
lua_pushnumber(L, double(k) + double(b) / 1024);
return 1;
}
case LUA_GCSTEP:
case LUA_GCISRUNNING:
{
Expand Down
Loading