Make extra Content persistent #398
Conversation
Add div that is the place the cached content are stored because content are never destroyed but only hidden Add elementsCache tool to handle communication between container and content Adapt fullscreen button with new logic for extra content
rearrange the class / style for consistency Comment verbose debug log that are no more necessaries Add fallback if error loading content
Clean up code Adjust CSS
try remote refresh using getElementById
… way to allows to use context instead of direct access
Rewrite of FullScreen management -WIP rewrite of Container helper to be consistent across all APP rewrite of FullScreenButton and CloseButton- WIP
Add some debug
comment events.off Add some debug
Fix wrong autorefresh of iframe due to useState for visibility Add notification of visibility state to extension
|
Hello @luc-github, |
|
Have a look to https://github.com/luc-github/ESP3D-WEBUI/tree/3.0/extensions the generic setup instructions are there : https://esp3d.io/ESP3D-WebUI/Version_3.X/documentation/extensions/ The detailed API is there : https://esp3d.io/ESP3D-WebUI/Version_3.X/documentation/api/extensions/ |
|
Thanks for your fast answer. I was looking in the location but I was missing the installation pictures for extensions, there was only 3 icons with missing content. Now I see them again 🙂. Then I add a additional pannel The result was: |
|
Do not put the .gz in address |
|
Ha, I just got it running. It looks like I can't use *.gz files for this extension... Edit:
Even better. |
|
This is working nice and I like it. Some impressions as feedback while I'm playing with the extension in Firefox (129.0.1v): The auto rotation of the 3D model seems to be a little rough compared with the rotation speed done by using the mouse. Guess, this is due to the calculation time within the browser. One thing I notice was that the origin 0,0,0 is placed in the back right instead of front left that most application use as reference. This is easily configurable via settings (thanks!). Maybe you want change the default so that peoples do not ask or complain for it all the time when they use the extension the first time. Same for top bottom view, the origin is in the top right corner instead of bottom left corner I was initially a bit confused about where the model should be loaded as the usual way is using the file panel in the dashboard or via drag&drop. I got used to it. Supporting drag&drop in addition would be nice. Regarding the GUI, comparing with the main GUI of ESP3D the items seems to be placed everywhere. One lonely menu item on the top two on the bottom and the quick view items on the top right side. When you resize the window w/o a model loaded the items for the different view buttons are floating sometimes to the top, to the right side or to the bottom (sometimes as well as two liner). The floating of the buttons are often not predictable: It is better when I load a model, but there are also quite often the buttons flowing unpredictable. Sometimes the view buttons and layer sliders went somewhere where i can't see them or end in some funny views for the menu buttons/sliders (i.e. when the window on the right starts to be too small): The font sizes of the menu items change sometimes depending on the windows size (what is nice), but the font size for the slider descriptions do not change, this is maybe why the auto placing of the items seems to be a little confused. I don't know if it is easily possible to put the sliders in vertical and horizontal orientation to the model window right and bottom. If not, I would prefer a fixed location at the bottom instead of floating somewhere. Perhaps grouping the menu items a little bit different can help: i.e. move the two buttons from the bottom to the top (there is a lot of space not used on the bottom for now). Move the file name in a second row and leave it alone. Helps maybe for the flow of the view buttons as well. In general it feels better having those buttons on the top and not on the right side or on the bottom of the window. Edit: An additional idea, Use icons instead of view buttons with text, like often used in slicer and CAD software. This will save a lot of space and is easier to group nicely together. Best regards, DD |
|
Thank you for your feedback: About your first issue: About auto rotation: About origin: About UI:
And Page: and full screen: That said I did not manage portrait view yet - only landscape, and I just noticed I have a scrollbar in Full screen which should not happen, need to adjust css again, the scrollbar on your screen should not be there so I am wondering what is your resolution to duplicate the issue About drag & Drop About icons of view button instead of text: I am not designer and this extension is more a Proof of Concept that the WebGL rendering can be done in less than13KB, more over, this my first project with 3D and WebGl so there are tons of improvement to be done for sure ... I am waiting for your resolution and will spend some time to improve css, portrait support was planned, but I forget it, busy with others projects / issues - I will find some time for it. Edit: |
|
Hello Luc, The screen solution on my test system is 1680x1050
This works nicely 👍
Don't worry, I'm quite impressed about what you are implementing in the project. Really. All I wrote is under the impression to give a honest feedback from one user w/o any ulterior motive. I was a little surprised that there is no other feedback so fare. Anyway, I did some more tests this morning with a bigger model (47 MB gcode). This time I add the panel view to the dashboard. Btw, I like this view very much. While loading and processing the model is nicely displayed with a process bar and more or less "fast", it took quite long (> 90 sec.) to show the model in the view w/o seeing that there are still some processes working for preparing the 3D view. After checking the process manager I understood what was going on. The memory consumption in Firefox increased up to 5.5 GB and the GPU uses additional 2.8 GB of memory in the graphic card. Bit's have to flow... I just recognize you pushed a new update while I'm writing this comment. You are so fast in updating your code 🙂 Best regards, DD |
The page view is now much better and the buttons do not jump around when I resize the browser window. 👍 |
|
You also should not see anymore a scrollbar - it should auto adjust size of canvas to avoid it, let me know if it happen |
|
It only happen if the browser window is too small, but this is ok as this indicate I need to resize the window better:
Maybe the space below the bottom icons can be optimized a little bit. |
|
Yes looks like I was generous on each bottom margin it should be better with latest 77 I have just pushed |
|
Much better. 🙂 |
Add Notifications message for extensions to inform then they are visible or not