-
Notifications
You must be signed in to change notification settings - Fork 0
Resolution analysis #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds “resolution analysis” utilities and updates reconstruction to support selecting events by a maximum neighbor count (enabling “all cluster sizes up to N”) while also making eta reconstruction fall back to centroid for non-2/3-pixel clusters.
Changes:
- Add
max_neighborsoption to reconstruction defaults/CLI/pipeline and use it to select acceptable cluster sizes. - Add new
hexsample.resolutionmodule plus ascripts/resolution.pydriver script for EEF/HEW studies. - Update
Cluster.eta()to return centroid when cluster size is not 2 or 3.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hexsample/tasks.py | Adds max_neighbors parameter and cluster-size filtering during reconstruction. |
| src/hexsample/pipeline.py | Threads max_neighbors through pipeline reconstruct() to the task. |
| src/hexsample/cli.py | Exposes --max_neighbors flag for reconstruction configuration. |
| src/hexsample/clustering.py | Makes eta() safe for non-2/3 pixel clusters by falling back to centroid. |
| src/hexsample/resolution.py | New analysis helpers for distance residuals, EEF, HEW, and spatial dependence. |
| scripts/resolution.py | New script to run and plot resolution analyses across thresholds/algorithms. |
| scripts/eta.py | Adds CLI-configurable zero-suppression threshold for eta calibration workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.