Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #768

Merged
merged 12 commits into from
Dec 8, 2024
Merged

PHP 8.4 #768

merged 12 commits into from
Dec 8, 2024

Conversation

kagg-design
Copy link
Contributor

No description provided.

@kagg-design
Copy link
Contributor Author

All tests for 8.0 - 8.3 were green. I'm not sure why tests for 8.4 are failing. It looks like a problem with the uopz extension.

@lucatume
Copy link
Owner

lucatume commented Dec 1, 2024

Thanks @kagg-design for the PR, you're on a roll.

Did you use rector to run the updates?

I will look into the failing tests and update this branch.

@kagg-design
Copy link
Contributor Author

Did you use rector to run the updates?

No, I used regular expressions.

@kagg-design
Copy link
Contributor Author

Found something more with

find . -name "*.php" -not -path "*/vendor/*" -exec php -l {} \;

The last changes now.

@lucatume
Copy link
Owner

lucatume commented Dec 3, 2024

After some digging, I think the issue lies in in this issue on the uopz extension repository.

I've run into the same issue while building the extension locally, and solved building from the branch in the PR.
Locally, I could run the failing tests without issues on PHP 8.4.

I will debug further should the issue persist.

Following
https://github.com/shivammathur/setup-php/wiki/Add-extension-from-source
instructions, build the PHP 8.4 compatible version of the `uopz`
extension from a PR branch that does not throw during the extension
compilation.
A limit of the serializable-closure library is the fact that class
constants will not be translated correctly prepending the
fully-qualified namespace name to them. Doing so explicitly removes the
need for automated resolution and fill in the gap.
@lucatume lucatume merged commit 4ebef1f into lucatume:master Dec 8, 2024
58 checks passed
@lucatume
Copy link
Owner

lucatume commented Dec 8, 2024

Finally able to merge and released in version 4.4.0

Thanks again @kagg-design, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants