-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.4 #768
PHP 8.4 #768
Conversation
All tests for 8.0 - 8.3 were green. I'm not sure why tests for 8.4 are failing. It looks like a problem with the uopz extension. |
Thanks @kagg-design for the PR, you're on a roll. Did you use rector to run the updates? I will look into the failing tests and update this branch. |
No, I used regular expressions. |
Found something more with find . -name "*.php" -not -path "*/vendor/*" -exec php -l {} \; The last changes now. |
After some digging, I think the issue lies in in this issue on the I've run into the same issue while building the extension locally, and solved building from the branch in the PR. I will debug further should the issue persist. |
Following https://github.com/shivammathur/setup-php/wiki/Add-extension-from-source instructions, build the PHP 8.4 compatible version of the `uopz` extension from a PR branch that does not throw during the extension compilation.
A limit of the serializable-closure library is the fact that class constants will not be translated correctly prepending the fully-qualified namespace name to them. Doing so explicitly removes the need for automated resolution and fill in the gap.
Finally able to merge and released in version Thanks again @kagg-design, much appreciated. |
No description provided.