Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml conversion of post addresses #324

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Fix yaml conversion of post addresses #324

merged 3 commits into from
Sep 13, 2023

Conversation

lucc
Copy link
Owner

@lucc lucc commented Sep 6, 2023

This fixes #323.

@lucc
Copy link
Owner Author

lucc commented Sep 6, 2023

@lemmerk can you confirm that this fixes your issue?

@skowalak do you know why you only returned the first address with 9ab66ac?
It looks the original code handles lists of addresses under one label:

9ab66ac#diff-a189618efcc4fcc11fb726bee1742df072e671aace70782e53e4b2b8c1074f70L1316-L1320

But the new code only picks the first list:

9ab66ac#diff-66dd891e1f121132ebda2ced9353326dc336e5a396c6f95511a4487d6df5f61cR124-R125

I could not find any discussion about this in #302 even though I made an unrelated comment about this piece of code #302 (comment)
I must have missed this issue back then.

@lemmerk
Copy link

lemmerk commented Sep 7, 2023

not sure how to check. followed the instructions in the dev section (i think) but it wouldn't run due to a missing version.py.

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/lemmerk/sandbox/khard/khard/__main__.py", line 3, in <module>
    from .khard import main
  File "/home/lemmerk/sandbox/khard/khard/khard.py", line 21, in <module>
    from . import cli
  File "/home/lemmerk/sandbox/khard/khard/cli.py", line 12, in <module>
    from .version import version as khard_version
ModuleNotFoundError: No module named 'khard.version'

@skowalak
Copy link
Contributor

skowalak commented Sep 7, 2023

@lucc You are right, my code apparently only picks the first address in the list. I cannot remember why this was introduced by me, thank you for fixing it!

@lucc
Copy link
Owner Author

lucc commented Sep 7, 2023

@lemmerk I suggest you enter a venv and then install with pip. I have to rewrite these notes some time but currently I am using nix flakes.

@lucc lucc merged commit 8b93dea into develop Sep 13, 2023
14 checks passed
@lucc lucc deleted the fix-323 branch September 13, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only one address shown when editing a contact with multiple {home,work} addresses
3 participants