H #2
Merged
H #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR standardizes project coordinates and enables publishing to GitHub Packages by updating the Gradle configuration with a fixed group ID and adding a Maven repository entry that uses environment-based credentials. Flow diagram for environment-based credentials in publishingflowchart TD
A[Gradle Build]
B[Read USERNAME from env]
C[Read TOKEN from env]
D[Configure Maven Repository]
E[Publish to GitHub Packages]
A --> B
A --> C
B --> D
C --> D
D --> E
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `build.gradle:80` </location>
<code_context>
- // Add publishing targets here if needed
+ maven {
+ name = "GitHubPackages"
+ url = uri("https://maven.pkg.github.com/${System.getenv('GITHUB_REPOSITORY')}")
+ credentials {
+ username = System.getenv("USERNAME")
+ password = System.getenv("TOKEN")
+ }
+ }
</code_context>
<issue_to_address>
Using environment variables for credentials is standard, but consider error handling for missing values.
Consider adding checks to ensure USERNAME, TOKEN, and GITHUB_REPOSITORY are set, and provide clear error messages if they are missing.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
repositories {
maven {
name = "GitHubPackages"
url = uri("https://maven.pkg.github.com/${System.getenv('GITHUB_REPOSITORY')}")
credentials {
username = System.getenv("USERNAME")
password = System.getenv("TOKEN")
}
}
}
=======
repositories {
// Check for required environment variables
def githubRepo = System.getenv('GITHUB_REPOSITORY')
def githubUsername = System.getenv('USERNAME')
def githubToken = System.getenv('TOKEN')
if (!githubRepo) {
throw new GradleException("Missing required environment variable: GITHUB_REPOSITORY")
}
if (!githubUsername) {
throw new GradleException("Missing required environment variable: USERNAME")
}
if (!githubToken) {
throw new GradleException("Missing required environment variable: TOKEN")
}
maven {
name = "GitHubPackages"
url = uri("https://maven.pkg.github.com/${githubRepo}")
credentials {
username = githubUsername
password = githubToken
}
}
}
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
77
to
86
| repositories { | ||
| // Add publishing targets here if needed | ||
| maven { | ||
| name = "GitHubPackages" | ||
| url = uri("https://maven.pkg.github.com/${System.getenv('GITHUB_REPOSITORY')}") | ||
| credentials { | ||
| username = System.getenv("USERNAME") | ||
| password = System.getenv("TOKEN") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
suggestion: Using environment variables for credentials is standard, but consider error handling for missing values.
Consider adding checks to ensure USERNAME, TOKEN, and GITHUB_REPOSITORY are set, and provide clear error messages if they are missing.
Suggested change
| repositories { | |
| // Add publishing targets here if needed | |
| maven { | |
| name = "GitHubPackages" | |
| url = uri("https://maven.pkg.github.com/${System.getenv('GITHUB_REPOSITORY')}") | |
| credentials { | |
| username = System.getenv("USERNAME") | |
| password = System.getenv("TOKEN") | |
| } | |
| } | |
| } | |
| repositories { | |
| // Check for required environment variables | |
| def githubRepo = System.getenv('GITHUB_REPOSITORY') | |
| def githubUsername = System.getenv('USERNAME') | |
| def githubToken = System.getenv('TOKEN') | |
| if (!githubRepo) { | |
| throw new GradleException("Missing required environment variable: GITHUB_REPOSITORY") | |
| } | |
| if (!githubUsername) { | |
| throw new GradleException("Missing required environment variable: USERNAME") | |
| } | |
| if (!githubToken) { | |
| throw new GradleException("Missing required environment variable: TOKEN") | |
| } | |
| maven { | |
| name = "GitHubPackages" | |
| url = uri("https://maven.pkg.github.com/${githubRepo}") | |
| credentials { | |
| username = githubUsername | |
| password = githubToken | |
| } | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update build configuration to publish artifacts to GitHub Packages and align the Maven group ID with the GitHub organization.
Enhancements: