Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pAE-related bugs #310

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix pAE-related bugs #310

merged 1 commit into from
Oct 17, 2024

Conversation

qiaoqiaoLF
Copy link
Contributor

In the paragraph 2 of section 4.3.2 of the AlphaFold3 supplementary materials, the variable $\Phi_i = (a_i, b_i, c_i)$ explicitly refers to the coordinates of the frame atoms, not the rotation matrix as previously implemented.

The prior implementation mistakenly calculated the rotation matrix for the frames based on the atom coordinates and then incorrectly set $\Phi_i$ to this rotation matrix. This led to a misalignment between the expected coordinates and the rotation matrix used during the alignment error computation.

The bug has been fixed by correctly assigning $\Phi_i$ as the coordinates of the frame atoms. Specifically:

  • The atom positions for the frame are now gathered and rearranged directly as $\Phi_i$, without first converting them into rotation matrices.
  • The alignment error is computed using the frame atom coordinates rather than their corresponding rotation matrices, ensuring consistency with the intended definition in the supplementary materials.

This fix ensures that the computed alignment error accurately reflects the comparison of atom positions as described in the AlphaFold3 documentation.

@lucidrains
Copy link
Owner

@qiaoqiaoLF thank you Lifeng! 🙏

@lucidrains lucidrains merged commit 2ad09e9 into lucidrains:main Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants