Closed
Conversation
Member
|
Awesome! Thanks for all your efforts! |
Member
|
Thanks :D I removed the CLI and other mosop deps from paulcsmith/cry since we weren't using those libs anyway. Rebased and added a new commit in #859 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Crystal::VERSIONcheck around URI.encode_www_form should be added if you want lucky to be warning free but also keep working in 0.29.0.You can double-check in crystal-lang/crystal#7997 which encode/decode method applies better.
A couple of dependencies need to be updated also as stated in bcardiff@053b559 after each of them are released. Do not use my forks as dependencies.
There is one fix I notice along the way regarding
distance_in_days.Feel free to use as-is or close and use as a reference.
Thanks for all the specs that helped us discovering crystal-lang/crystal#8020 before releasing.