Fix range variables

Range variables were being reused in some loops in the tests
lucmq · Jun 15, 2024 · f3be7ef · f3be7ef
1 parent 35ad4b5
commit f3be7ef
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/driver/test/db_main.go b/driver/test/db_main.go
@@ -278,7 +278,8 @@ func (T *DBTests) TestPut(t *testing.T) {
 
 		// Act
 		var wg sync.WaitGroup
-		for key, value := range seed {
+		for k, v := range seed {
+			key, value := k, v // Capture
 			wg.Add(1)
 			go func() {
 				defer wg.Done()
@@ -364,7 +365,8 @@ func (T *DBTests) TestDelete(t *testing.T) {
 
 		// Act
 		var wg sync.WaitGroup
-		for key, _ := range seed {
+		for k, _ := range seed {
+			key := k // Capture
 			wg.Add(1)
 			go func() {
 				defer wg.Done()

diff --git a/sdb/db_bench_test.go b/sdb/db_bench_test.go
@@ -98,15 +98,15 @@ func BenchmarkDB_Put_Concurrent(b *testing.B) {
 		b.ResetTimer()
 		for i := 0; i < b.N; i++ {
 			ch <- 1
-			go func() {
+			go func(i int) {
 				wg.Add(1)
 				defer wg.Done()
 				defer func() { <-ch }()
 				err := db.Put(items[i%N][0], items[i%N][1])
 				if err != nil {
 					b.Fatalf("put: %s", err)
 				}
-			}()
+			}(i)
 			inserted++
 		}
 		wg.Wait()

diff --git a/sdb/db_main_test.go b/sdb/db_main_test.go
@@ -278,7 +278,8 @@ func (T *DBTests) TestPut(t *testing.T) {
 
 		// Act
 		var wg sync.WaitGroup
-		for key, value := range seed {
+		for k, v := range seed {
+			key, value := k, v // Capture
 			wg.Add(1)
 			go func() {
 				defer wg.Done()
@@ -364,7 +365,8 @@ func (T *DBTests) TestDelete(t *testing.T) {
 
 		// Act
 		var wg sync.WaitGroup
-		for key, _ := range seed {
+		for k, _ := range seed {
+			key := k // Capture
 			wg.Add(1)
 			go func() {
 				defer wg.Done()