fix: improve CBO analysis with Union type support and score calibration #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for Python 3.10+ Union types (X | Y) in CBO analysis - Parse type annotations as AST nodes instead of strings for accurate analysis - Handle Union types in both function parameters and return types - Adjust CBO score threshold from 12% to 25% for more realistic scoring Before this fix, Union type annotations like `ctx: Context | None` were not detected, resulting in artificially low CBO values. For example, click's Command class had CBO=3 when it should have been CBO=7.
…rence Move return type annotation from Children to Right field in FunctionDef nodes. This prevents DFA analysis from treating type names as variable uses, which would distort data-flow metrics. - FunctionDef.Right now holds the return type AST node - CBO analyzer updated to read from Right instead of Children - Arg.Children still holds parameter type annotations (not affected by DFA)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
X | Y) in CBO analysisProblem
Before this fix, Union type annotations like
ctx: Context | Nonewere not detected, resulting in artificially low CBO values. For example, a class with CBO=3 should actually have been CBO=7.CBO scores were also too harsh (0 or 100 with nothing in between).
Changes
Parser (
internal/parser/ast_builder.go)CBO Analyzer (
internal/analyzer/cbo.go)NodeBinOphandling for Union types (X | Y)Score Calibration (
domain/analyze.go)Test plan