fix: use floor_char_boundary to prevent UTF-8 panic on string truncation#37
Merged
fix: use floor_char_boundary to prevent UTF-8 panic on string truncation#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed panics caused by slicing strings at non-char-boundary byte offsets. Uses
floor_char_boundary()to find the nearest valid UTF-8 boundary.Fixed in 4 locations:
stream.rs: tool result preview truncation (200 bytes)executor.rs: approval notification (2000 bytes)executor.rs: Discord message truncation (1900 bytes)executor.rs: email context truncation (3000 bytes)Test plan