LCM brightness values are passed as uint8 0..100 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I noted in the first PR, could you please add a "Fix: Fix setting brightness for LCM modules." to the end of the commit message of the fix? I'm trying to adopt a system for automatic changelog generation, it's a bit hairy at the moment, to my dismay. The way it works is you add a "Fix: ..." or a "Feature: ..." at the end of the commit message. It's called a git trailer, same as "Signed-off-by: " that you use. I then have a script (it's in the root of the package) that collects these and dumps them into a piece of markdown. It unfortunately doesn't handle multiline text too well 😞 |
Convert brightness from 0..1 float to 0..100 integer Fix: Fix setting brightness for LCM module (Floatwheel) Signed-off-by: Dado Mista <dadomista@gmail.com>
lukash
pushed a commit
that referenced
this pull request
May 31, 2024
lukash
pushed a commit
that referenced
this pull request
Sep 15, 2024
27a91f2 Merge pull request #2 from r3n33/update/profile-view 449ac43 Import colors.lisp 9b25e1e More spelling errors eedd443 Fix spelling 55e4b53 Adding color to profile selection view git-subtree-dir: vdisp git-subtree-split: 27a91f26a00f7735b3b4a8910d6fdef6511ed78c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert brightness from 0..1 float to 0..100 integer