Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for @title keyword annotation #1657

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DominykasValutis
Copy link

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Put closes #1656

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there DominykasValutis 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@stskrp stskrp mentioned this pull request Aug 14, 2024
4 tasks
@github-actions github-actions bot added the Stale label Sep 2, 2024
Repository owner deleted a comment from github-actions bot Sep 2, 2024
@WoH WoH removed the Stale label Sep 2, 2024
@WoH
Copy link
Collaborator

WoH commented Sep 2, 2024

Sorry for the delay. Could you add a test to make sure this doesn´t break accidentally?

@DominykasValutis
Copy link
Author

@WoH could you guide me for which component you want me to add test, cannot find any previous test for validatorUtils.ts file

@WoH
Copy link
Collaborator

WoH commented Sep 18, 2024

There are no tests for that file explicitly, but you can add an annotation in the test fixtures and add an assertion for OpenAPI V2 / V3 here:

https://github.com/lukeautry/tsoa/tree/master/tests%2Funit%2Fswagger

schemaDetails(3).ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants