-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support string variable in the first argument of @Extension #1677
Merged
WoH
merged 20 commits into
lukeautry:master
from
chappelo:feat/string-variable-@Extension-support
Sep 26, 2024
Merged
feat: Support string variable in the first argument of @Extension #1677
WoH
merged 20 commits into
lukeautry:master
from
chappelo:feat/string-variable-@Extension-support
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, @WoH , if you have time can you take a look at this CI build error please? Looks like lru-cache had some updates last week which might be causing this? are some package updates appropriate? |
Should be fixed now, can you rebase? |
chappelo
force-pushed
the
feat/string-variable-@Extension-support
branch
from
September 23, 2024 11:27
ffc6c46
to
a865a2c
Compare
Cool, all works well now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
closes #1520
Adds support of string identifiers to be passed into
@Extension
's attribute key.This is accomplished by adding
ts.isIdentifier
checks intogetExtensions
. If it is an identifier ->getInitializerValue()
If this is a new feature submission:
Potential Problems With The Approach
Test plan
I added test case to the existing extensions tests.