Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): methodOverride cause lint fail #1693

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jackey8616
Copy link
Collaborator

@jackey8616 jackey8616 commented Oct 3, 2024

The method-override package's method somehow causing lint error.
After digging into package version and @types definitions, I cannot find any error on it causing eslint error.
Thus re-wrap the calling with arrow functions.

Interesting thing is that : typescript 5.6.2 is fine.

note: this should fix the CI error @ 2c85ac9 and e04625e.

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

@jackey8616 jackey8616 self-assigned this Oct 3, 2024
@jackey8616 jackey8616 merged commit d8c881a into master Oct 3, 2024
37 checks passed
@jackey8616 jackey8616 deleted the fix/no-misused-promises branch October 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant