Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Closing issues
If this is a new feature submission:
Please comment if handling Models with multiple type parameters is not something you want to support and I'll
throw
on that :)Potential Problems With The Approach
This PR assumes the scope of the type arguments has been checked by typescript (which is reasonable I think).
Edit: I don't like the implementation, but it's a lot less bad :/
Test plan
I'm sure there are millions of possible scenarios we want to spec here, I have no clue what to cover yet, I intend to keep this a draft until this section is less depressing to read.