💄 Use dynamic height for mobile

[lukevella]

Summary by CodeRabbit

• Style
  • Updated viewport height styling to use dvh (dynamic viewport height) instead of screen for improved responsiveness across different devices and screen sizes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 28, 2025 9:01pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
landing	⬜️ Skipped (Inspect)			Jan 28, 2025 9:01pm

[coderabbitai]

Walkthrough

The pull request introduces a subtle change in the web application's authentication layout by modifying the height class of a div element. The modification replaces the traditional h-screen viewport height class with h-dvh, which represents the dynamic viewport height. This change aims to improve layout rendering, particularly on devices with variable screen dimensions or browser interfaces.

Changes

File	Change Summary
apps/web/src/app/[locale]/(auth)/layout.tsx	Replaced h-screen with h-dvh for dynamic viewport height styling

Poem

🐰 A rabbit's height class tale unfolds,
From screen to dynamic, boldly told
h-dvh now sets the stage just right
Adapting views with pixel might
Responsive magic, code so neat! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0117464 and 300786e.

📒 Files selected for processing (1)

• apps/web/src/app/[locale]/(auth)/layout.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Unit tests
• GitHub Check: Type check
• GitHub Check: Integration tests
• GitHub Check: Linting

🔇 Additional comments (1)

apps/web/src/app/[locale]/(auth)/layout.tsx (1)

17-17: Great improvement for mobile layouts! 📱

Using h-dvh instead of h-screen is a smart choice as it handles dynamic viewport height changes on mobile browsers (e.g., when the address bar shows/hides).

However, let's verify browser support and consider adding a fallback:

Consider adding a fallback for older browsers:

-    <div className="relative flex h-dvh flex-col items-center justify-center bg-gray-100 p-2 lg:p-4">
+    <div className="relative flex h-screen h-dvh flex-col items-center justify-center bg-gray-100 p-2 lg:p-4">

✅ Verification successful

✅ Browser support for dvh is sufficient

The dvh unit has been supported in all major browsers since 2022 (Safari 15.4+, Chrome 108+, Firefox 101+). The change improves mobile UX without requiring a fallback.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check browser support for dvh unit
curl -s "https://caniuse.com/api/features?ids=viewport-unit-variants" | jq '.data."viewport-unit-variants".stats'

Length of output: 115

---

Script:

#!/bin/bash
# Install and check MDN compatibility data
npm install -g @mdn/browser-compat-data
echo "Checking dvh support..."
node -e "const bcd = require('@mdn/browser-compat-data'); console.log(JSON.stringify(bcd.css.properties.height.dvh, null, 2))"

# Search for existing dvh usage in the codebase
echo -e "\nChecking existing dvh usage..."
rg "h-dvh" -t css -t tsx -t jsx

Length of output: 2781

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.