Skip to content

Conversation

@doublegate
Copy link

  • Addition of required files for compile targets

Copilot AI review requested due to automatic review settings June 7, 2025 22:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds and modifies necessary files to ensure successful compilation. Key changes include:

  • Updating the logging initialization in tetanes/src/main.rs for early error handling.
  • Adjusting bit flag positions and adding Debug for the Cpu struct in tetanes-core/src/cpu.rs.
  • Updating dependency versions and workspace configuration in Cargo.toml files.
  • Including new VS Code configuration files for building and debugging.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tetanes/src/main.rs Streamlined logging initialization and refined Nes::run call.
tetanes-core/src/cpu.rs Adjusted bit flag positions and added Debug to Cpu struct.
tetanes-core/Cargo.toml Updated bitflags dependency configuration via workspace.
Cargo.toml Revised workspace membership and updated dependency versions.
.vscode/settings.json Added VS Code setting to disable C++ build.
.vscode/launch.json Introduced multiple debug configurations for build targets.
Comments suppressed due to low confidence (3)

tetanes-core/Cargo.toml:33

  • Switching to the workspace version for the bitflags dependency may affect features (e.g., 'serde'). Verify that the workspace version (currently set to 2.4.1 in the global Cargo.toml) provides all required functionality.
bitflags = { workspace = true }

Cargo.toml:6

  • The removal of 'tetanes-utils' from the workspace members could impact parts of the project that depend on it. Confirm that this change is deliberate and that any dependencies on tetanes-utils have been appropriately addressed.
members = ["tetanes", "tetanes-core"]

tetanes-core/src/cpu.rs:43

  • The bit flag positions for Irq have been shifted (from 1<<1 to 1<<0, etc.). Confirm that this change is intentional and that all downstream code consuming these flags has been updated accordingly.
const MAPPER = 1 << 0;

@lukexor
Copy link
Owner

lukexor commented Jun 7, 2025

Some of the changes here are good for general cleanup, but this PR is out of date. I switched away from SDL for rendering quite awhile back.

As for versions, I explicitly opted into not pinning patch versions until I release a stable 1.0 release. Also while the vscode file is fine, I don't and won't ever use it, so it's a maintenance cost I'm unsure I'd like to take on to keep it up to date

If you're still interested in merging the cleanup changes and want to address those items (removing SDL, and the patch versions) I'll consider merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants