Fix WebAuthN Issue #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug with WebAuthN registration that occured around v21. Backwards-compatible with earlier versions
|
Uncaught Reference Error: registerSecurityKey is not defined |
@youss6f That doesn't really look like something this PR would cause, are there any other error messages before that one that would indicate otherwise? Under which circumstances/with which versions are you getting this error? |
|
I had the same problem on Keycloak version 23.0.6 But I forgot to copy the " at the end of the line. After applying the whole change the registration worked as expected. @youss6f Did you make the same misstake? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug with WebAuthN registration that occured around v21, resolves #57, #76 . Backwards-compatible with earlier versions
Suggestion by @paulwer #57 (comment)
I've tested it with pre-21 and post-21 versions, seems to work well up to the newest version.