Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve contracts section for Tokens & NFTs (LSP7 + LSP8) #1156

Merged
merged 8 commits into from
Oct 21, 2024
Merged

improve contracts section for Tokens & NFTs (LSP7 + LSP8) #1156

merged 8 commits into from
Oct 21, 2024

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Oct 18, 2024 •
edited
Loading

image image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

JeneaVranceanu
JeneaVranceanu reviewed Oct 21, 2024
View reviewed changes
docs/standards/tokens/introduction.md Outdated Show resolved Hide resolved
docs/contracts/overview/NFT/customise-transfer-behaviour.md

# Customize transfer behaviour

The `LSP8IdenfitiableDigitalAsset` contract implementation includes the `_beforeTokenTransfer` and `_afterTokenTransfer` functions that offer the ability to specify custom logic that can run before or after the token transfer has happen (= before or after the balances in the contract state have been updated).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give code examples for those functions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will but haven't found a good example so far to showcase like in LSP7. I will do in a separate PR

docs/contracts/overview/NFT/index.md Outdated Show resolved Hide resolved
docs/contracts/overview/Token/create-token.md Outdated Show resolved Hide resolved
docs/contracts/overview/NFT/create-nft-collection.md Outdated Show resolved Hide resolved
docs/contracts/overview/Token/customise-transfer-behaviour.md Outdated Show resolved Hide resolved
docs/contracts/overview/Token/customise-transfer-behaviour.md Outdated Show resolved Hide resolved
docs/contracts/overview/Token/customise-transfer-behaviour.md Outdated Show resolved Hide resolved
@CJ42 CJ42 merged commit c6992c0 into main Oct 21, 2024
2 checks passed
@CJ42 CJ42 deleted the docs/contracts-section branch October 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeneaVranceanu JeneaVranceanu JeneaVranceanu left review comments

@b00ste b00ste Awaiting requested review from b00ste b00ste is a code owner

@skimaharvey skimaharvey Awaiting requested review from skimaharvey skimaharvey is a code owner

@YamenMerhi YamenMerhi Awaiting requested review from YamenMerhi YamenMerhi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CJ42 @JeneaVranceanu