docs: rename LSP3 Standard to Profile-Metadata #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
YamenMerhi
commented
Aug 2, 2023
YamenMerhi
commented
- rename LSP3 Standard to Profile-Metadata
CJ42
requested changes
Aug 3, 2023
| @@ -42,7 +42,7 @@ Complete "ready to use" JSON and JS files are available at the end in the [**Fin | |||
|
|
|||
| To inspect the address and check if it has an ERC725 contract, we can call its interface through the `erc725.js` library. The instance of the contract will need the following information: | |||
|
|
|||
| - [LSP3 - Universal Profile Metadata](../../standards/universal-profile/lsp3-universal-profile-metadata) describes the data in the Universal Profile contract storage, and which keys to use to retrieve it. We can import the schema directly from the [erc725.js](../../tools/erc725js/schemas#standard-lsp-schemas) library. | |||
| - [LSP3 - Universal Profile Metadata](../../standards/universal-profile/lsp3-profile-metadata) describes the data in the Universal Profile contract storage, and which keys to use to retrieve it. We can import the schema directly from the [erc725.js](../../tools/erc725js/schemas#standard-lsp-schemas) library. | |||
|
|
|||
| - `SupportedStandards` shows the interface using a Metadata Standard with a key. In our case we use `SupportedStandards:LSP3UniversalProfile` from to check if the contract is a Universal Profile. | |||
There was a problem hiding this comment.
This data key has to be changed as well I guess? Based on this comment: lukso-network/LIPs#220 (comment)
Suggested change
| - `SupportedStandards` shows the interface using a Metadata Standard with a key. In our case we use `SupportedStandards:LSP3UniversalProfile` from to check if the contract is a Universal Profile. | |
| - `SupportedStandards` shows the interface using a Metadata Standard with a key. In our case we use `SupportedStandards:LSP3Profile` from to check if the contract is a Universal Profile. |
There was a problem hiding this comment.
This will be part of a larger discussion with Fabian. Can be done in another PR once we have a definitive answer
There was a problem hiding this comment.
Nice was about to comment but realised that this was also changed in the lsp-factory.js docs 👌
So the CI will not need to open a PR to update it I guess, because it's in sync! 💪
https://github.com/lukso-network/tools-lsp-factory/pull/198/files
Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
CJ42
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.