-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LUKSO web3-onboard documentation #617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancabuzea200
requested review from
fhildeb,
CJ42,
YamenMerhi and
Hugoo
as code owners
September 6, 2023 15:31
Task linked: DEV-8137 document web3-onboard |
asciiman
reviewed
Sep 6, 2023
asciiman
reviewed
Sep 6, 2023
Co-authored-by: Stephen Horvath <stephen@futureagency.io>
Co-authored-by: Stephen Horvath <stephen@futureagency.io>
asciiman
reviewed
Sep 6, 2023
asciiman
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Stephen Horvath <stephen@futureagency.io>
Hugoo
reviewed
Sep 7, 2023
Comment on lines
+1
to
+3
# Connect users' wallets to your Dapp with web3-onboard | ||
|
||
### The easiest way to connect a wallet 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we go from h1 to h3 directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/2645698/DEV-8137