Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new hardhat guides + collapsed all #618

Merged
merged 7 commits into from
Sep 7, 2023
Merged

new hardhat guides + collapsed all #618

merged 7 commits into from
Sep 7, 2023

Conversation

kalote
Copy link
Contributor

@kalote kalote commented Sep 7, 2023

New hardhat related guides:

  • new folder
  • new guides

I also changed the collpased: false on network / browser extension

Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR.

This repo uses yarn, could you remove the package-lock.json file from the PR please?

Also, the yarn.lock change might not be needed either. Thanks

image

Comment on lines 43 to 55
### Create the prettier config

Create a new file at the root of your project called `.prettierrc` with the following content:

```json title="Create the prettier config"
{
"trailingComma": "all",
"tabWidth": 2,
"semi": true,
"singleQuote": true,
"printWidth": 110
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this important for this guide?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to have a good "complete" setup, which is why i put it here. So not mandatory, but definitely part of the dapp dev journey

kalote and others added 3 commits September 7, 2023 10:39
"Click" typo and prettier space in "note" and "warning" blocks

Co-authored-by: Hugo Masclet <hugo@lukso.io>

# Setup your Hardhat project

In this article will guide you through the process of seting up an Hardhat installation (using TypeScript), adding the [`@lukso/lsp-smart-contracts`](https://www.npmjs.com/package/@lukso/lsp-smart-contracts) package, creating a basic LSP7 contract, and deploying it on [LUKSO Testnet](http://docs.lukso.tech/networks/testnet/parameters).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you to add which version you used for this guide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use absolute links, only relative here. I'll fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


```js title="Install dependencies"
npm i -D dotenv prettier
npm i -s @lukso/lsp-smart-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this install can be on a specific version so it is reproductible ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


# Setup your Hardhat project

In this article will guide you through the process of seting up an Hardhat installation (using TypeScript), adding the [`@lukso/lsp-smart-contracts`](https://www.npmjs.com/package/@lukso/lsp-smart-contracts) package, creating a basic LSP7 contract, and deploying it on [LUKSO Testnet](http://docs.lukso.tech/networks/testnet/parameters).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use absolute links, only relative here. I'll fix

### Install dependencies

```js title="Install dependencies"
npm i -D dotenv prettier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's take prettier out of this guide so we can focus only on LUKSO stuff

@Hugoo Hugoo merged commit b0d16a8 into main Sep 7, 2023
2 checks passed
@Hugoo Hugoo deleted the feat/hardhat-base-setup branch September 7, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants