-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new hardhat guides + collapsed all #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Create the prettier config | ||
|
||
Create a new file at the root of your project called `.prettierrc` with the following content: | ||
|
||
```json title="Create the prettier config" | ||
{ | ||
"trailingComma": "all", | ||
"tabWidth": 2, | ||
"semi": true, | ||
"singleQuote": true, | ||
"printWidth": 110 | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this important for this guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's important to have a good "complete" setup, which is why i put it here. So not mandatory, but definitely part of the dapp dev journey
"Click" typo and prettier space in "note" and "warning" blocks Co-authored-by: Hugo Masclet <hugo@lukso.io>
76d6c16
to
d6ae23f
Compare
|
||
# Setup your Hardhat project | ||
|
||
In this article will guide you through the process of seting up an Hardhat installation (using TypeScript), adding the [`@lukso/lsp-smart-contracts`](https://www.npmjs.com/package/@lukso/lsp-smart-contracts) package, creating a basic LSP7 contract, and deploying it on [LUKSO Testnet](http://docs.lukso.tech/networks/testnet/parameters). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you to add which version you used for this guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use absolute links, only relative here. I'll fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
```js title="Install dependencies" | ||
npm i -D dotenv prettier | ||
npm i -s @lukso/lsp-smart-contracts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this install can be on a specific version so it is reproductible ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
# Setup your Hardhat project | ||
|
||
In this article will guide you through the process of seting up an Hardhat installation (using TypeScript), adding the [`@lukso/lsp-smart-contracts`](https://www.npmjs.com/package/@lukso/lsp-smart-contracts) package, creating a basic LSP7 contract, and deploying it on [LUKSO Testnet](http://docs.lukso.tech/networks/testnet/parameters). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use absolute links, only relative here. I'll fix
### Install dependencies | ||
|
||
```js title="Install dependencies" | ||
npm i -D dotenv prettier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's take prettier out of this guide so we can focus only on LUKSO stuff
New hardhat related guides:
I also changed the
collpased: false
on network / browser extension