Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LUKSO web-components, ERC725JS #2

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Add LUKSO web-components, ERC725JS #2

merged 9 commits into from
Jan 16, 2025

Conversation

mustafademiray
Copy link
Contributor

this PR contains a little clean up, as well as adds erc725js and lukso/web-components to the repo

@github-actions GitHub Actions
Copy link

Deployed with Cloudflare Pages ☁️ 🚀 🆗

dzbo
dzbo requested changes Jan 13, 2025
View reviewed changes
Copy link

@dzbo dzbo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take advantage of our web components and limit code to minimum

app/layout.tsx Outdated Show resolved Hide resolved
components/ui/button.tsx Outdated Show resolved Hide resolved
tailwind.config.ts Outdated Show resolved Hide resolved
tailwind.config.ts Outdated Show resolved Hide resolved
types/globals.d.ts Outdated Show resolved Hide resolved
app/LuksoWebComponentsProvider.tsx Outdated Show resolved Hide resolved
components/Donate.tsx Outdated Show resolved Hide resolved
components/LuksoUsername.tsx Outdated Show resolved Hide resolved
components/Search.tsx Outdated Show resolved Hide resolved
components/Search.tsx Outdated Show resolved Hide resolved
doubleppereira
doubleppereira reviewed Jan 13, 2025
View reviewed changes
app/globals.scss Outdated Show resolved Hide resolved
dzbo
dzbo reviewed Jan 14, 2025
View reviewed changes
lib/utils.ts Outdated Show resolved Hide resolved
@doubleppereira doubleppereira requested a review from dzbo January 15, 2025 15:08
doubleppereira
doubleppereira approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@doubleppereira doubleppereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a nit pick comments

dzbo
dzbo reviewed Jan 15, 2025
View reviewed changes
Copy link

@dzbo dzbo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's enhance this example with proper comments. Every function should have own comment, please follow JSDOC structure. Every crucial code block within function should also have own comment.

@mustafademiray mustafademiray requested a review from dzbo January 16, 2025 11:08
@mustafademiray mustafademiray merged commit 4178fe7 into main Jan 16, 2025
1 check passed
@dzbo dzbo deleted the fetch-profile-erc725 branch January 16, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzbo dzbo dzbo approved these changes

@doubleppereira doubleppereira doubleppereira approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustafademiray @dzbo @doubleppereira