-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: upgrade to contracts v0.12.0 + add tokenIdType
to LSP8 deployment
#226
Conversation
@erc725/erc725.js
+ @lukso/lsp-smart-contracts
to latest versionstokenIdType
to LSP8 deployment
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #226 +/- ##
===========================================
- Coverage 19.72% 19.18% -0.55%
===========================================
Files 16 15 -1
Lines 1034 1058 +24
Branches 358 371 +13
===========================================
- Hits 204 203 -1
- Misses 808 832 +24
- Partials 22 23 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thanks! Can we make the LSP8 tokenID type default to some value if not provided?
Also we will need the new verified base contract addresses in the versions.json
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b0a9d46
to
97ce334
Compare
@CJ42 Can you fix the lint errors? The import order plugin is a bit particular in terms of the sequence and separation of various imports. They can be fixed in vscode or with --fix in eslint. |
bcf18e4
to
143ea7c
Compare
a199e9e
to
bd6ea52
Compare
bd6ea52
to
adbaadc
Compare
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
@erc725/erc725.js
to v0.20.0 +@lukso/lsp-smart-contracts
to v0.12.0tokenIdType
on deployment of LSP8 contract.@lukso/lsp-smart-contracts
package.🧪 Tests
getData
instead ofgetDataBatch
when possible.