Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: update LSP3 and LSP4 to new verification schema #228

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

CallumGrindle
Copy link
Contributor

TODO: Build will break until we update with erc725.js changes

Copy link
Contributor

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. There is something going on with the jest stuff.

@CallumGrindle CallumGrindle force-pushed the update-metadata branch 2 times, most recently from 62fbad3 to 99c3051 Compare November 3, 2023 08:07
@codecov-commenter
Copy link

Codecov Report

Merging #228 (acaa377) into develop (ca39a3a) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop     #228   +/-   ##
========================================
  Coverage    19.60%   19.60%           
========================================
  Files           15       15           
  Lines         1066     1066           
  Branches       373      373           
========================================
  Hits           209      209           
  Misses         834      834           
  Partials        23       23           
Files Coverage Δ
src/lib/helpers/uploader.helper.ts 42.85% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@CallumGrindle CallumGrindle merged commit 4bc7edf into develop Nov 3, 2023
1 check passed
@CallumGrindle CallumGrindle deleted the update-metadata branch November 3, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants