-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LUM-843] Disable Beam & Dfract modules #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the burn process is functional, we need to use the bank module for this.
Also we are missing the following:
- Remove CLI commands for deprecated modules
- Remove Query handlers for deprecated modules
Beams: beams, | ||
ModuleAccountBalance: k.GetBeamAccountBalance(ctx), | ||
} | ||
return &types.GenesisState{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we return nil
here to prevent empty state population ?
DepositsPendingMint: k.ListDepositsPendingMint(ctx), | ||
DepositsPendingWithdrawal: k.ListDepositsPendingWithdrawal(ctx), | ||
} | ||
return &types.GenesisState{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
This reverts commit 22be9b9.
Introduction
As announced, the Lum Network is sunsetting the Beam & DFract modules.
This pull request introduce migrations for proper sunsetting, by making sure no coin is left behind or any entity in a pending state.
Testing
Unit tests were added.
Public testnet is going to be upgraded before