Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUM-843] Disable Beam & Dfract modules #57

Merged
merged 17 commits into from
Oct 20, 2023
Merged

[LUM-843] Disable Beam & Dfract modules #57

merged 17 commits into from
Oct 20, 2023

Conversation

Segfaultd
Copy link
Member

@Segfaultd Segfaultd commented Oct 19, 2023

Introduction

As announced, the Lum Network is sunsetting the Beam & DFract modules.
This pull request introduce migrations for proper sunsetting, by making sure no coin is left behind or any entity in a pending state.

Testing

Unit tests were added.
Public testnet is going to be upgraded before

Copy link
Contributor

@lebascou lebascou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the burn process is functional, we need to use the bank module for this.
Also we are missing the following:

  • Remove CLI commands for deprecated modules
  • Remove Query handlers for deprecated modules

Beams: beams,
ModuleAccountBalance: k.GetBeamAccountBalance(ctx),
}
return &types.GenesisState{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we return nil here to prevent empty state population ?

DepositsPendingMint: k.ListDepositsPendingMint(ctx),
DepositsPendingWithdrawal: k.ListDepositsPendingWithdrawal(ctx),
}
return &types.GenesisState{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

x/dfract/migrations/v162/store.go Show resolved Hide resolved
@Segfaultd Segfaultd marked this pull request as ready for review October 20, 2023 09:46
@lebascou lebascou mentioned this pull request Oct 20, 2023
2 tasks
@lebascou lebascou merged commit 9e2e5f7 into master Oct 20, 2023
5 checks passed
@lebascou lebascou deleted the feature/lum-843 branch November 15, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants